Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/name version conanbuildinfo txt #6723

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 24, 2020

Changelog: Bugfix: Include name and version in the data from conanbuildinfo.txt, so it is available in self.deps_cpp_info["dep"].version and self.deps_cpp_info["dep"].name, so it can be used in conan build and in test_package/conanfile.py.
Docs: conan-io/docs#1626

Close #6695

@memsharded memsharded added this to the 1.24 milestone Mar 24, 2020
Copy link
Member

@jgsogo jgsogo left a comment

I doubt about the expected result. I understand that name might be confusing. Maybe it is better to provide a self.deps_cpp_info["xxxxx"].reference with the full Conan reference (without revisions and package_id).

Related to this issue (#6669)

jgsogo
jgsogo approved these changes Mar 24, 2020
Copy link
Member

@jgsogo jgsogo left a comment

Ok, understood the underlying issue. Here we are documenting and ensuring the value that the field .version has for all the scenarios (it was not working for the test_package one).

@jgsogo jgsogo merged commit a981efe into conan-io:develop Mar 24, 2020
2 checks passed
@memsharded memsharded deleted the feature/name_version_conanbuildinfo_txt branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants