Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix package_id computation for mixed modes #6947

Merged
merged 5 commits into from
May 4, 2020
Merged

fix package_id computation for mixed modes #6947

merged 5 commits into from
May 4, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 3, 2020 •
edited by czoido
Loading

Changelog: Bugfix: Prevent crash when mixing package_id modes for the same dependency.
Docs: Omit

Close #6942

@memsharded memsharded mentioned this pull request May 3, 2020
Closed
@memsharded memsharded added this to the 1.25 milestone May 3, 2020
jgsogo
jgsogo suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding some questions. I don't understand what was broken and why this fixes it.

conans/client/graph/graph.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/model/ref.py Show resolved Hide resolved
jgsogo
jgsogo approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the CI 👍

@czoido czoido merged commit 0f1bd5a into conan-io:develop May 4, 2020
@memsharded memsharded deleted the fix/package_id_mixed branch May 4, 2020 14:27
@memsharded memsharded mentioned this pull request May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.

[bug] unable to build packages with package_revision_mode enabled.
3 participants
@memsharded @jgsogo @czoido