Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package_id computation for mixed modes #6947

Merged
merged 5 commits into from May 4, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 3, 2020

Changelog: Bugfix: Prevent crash when mixing package_id modes for the same dependency.
Docs: Omit

Close #6942

Copy link
Member

@jgsogo jgsogo left a comment

I'm adding some questions. I don't understand what was broken and why this fixes it.

conans/client/graph/graph.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/model/ref.py Show resolved Hide resolved
jgsogo
jgsogo approved these changes May 4, 2020
Copy link
Member

@jgsogo jgsogo left a comment

Let's wait for the CI 👍

@czoido czoido merged commit 0f1bd5a into conan-io:develop May 4, 2020
2 checks passed
@memsharded memsharded deleted the fix/package_id_mixed branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants