Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Added support for '.' in pkg_name for python_requires_extend #7242

Closed

Conversation

LBHawk
Copy link

@LBHawk LBHawk commented Jun 23, 2020

Closes #7241

Changelog: (Bugfix): Added support for '.' in pkg_name for python_requires_extend

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@memsharded
Copy link
Member

Hi @LBHawk

The test that is failing in CI is unrelated, don't worry about it, it is already fixed.

Please:

  • Add a red-green test for this new behavior, to guarantee no future regressions
  • Please sign the CLA above, check if you did the commit with the same Github user

Many thanks for contributing this fix!

@memsharded memsharded added this to the 1.27 milestone Jun 23, 2020
@memsharded memsharded self-assigned this Jun 28, 2020
@memsharded memsharded removed this from the 1.27 milestone Jun 29, 2020
@memsharded
Copy link
Member

This was implemented and fixed in #7262
Thanks for your contribution!

@memsharded memsharded closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Unable to python_requires_extend a package with a '.' in the name
4 participants