Fix Conan V2 cli broken help #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 21, 2020
| @@ -81,13 +81,15 @@ def __init__(self, conan_api): | |||
| self._commands = {} | |||
| conan_commands_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), "commands") | |||
| for module in pkgutil.iter_modules([conan_commands_path]): | |||
| self._add_command("conans.cli.commands.{}".format(module.name), module.name) | |||
| module_name = module[1] | |||
There was a problem hiding this comment.
Is this a Py2.7 thing? If that is the case, I am happy with the check you did in the test to run the test only in Py3
There was a problem hiding this comment.
This is because in 3.5 they changed the return from a tuple to a named tuple for iter_modules return value:
https://docs.python.org/3.5/library/pkgutil.html#pkgutil.iter_modules
https://docs.python.org/3.6/library/pkgutil.html#pkgutil.iter_modules
Python2 issue is another one.
| from conans.test.utils.tools import TestClient | ||
|
|
||
|
|
||
| @unittest.skipIf(six.PY2, "v2.0: Only testing for Python 3") |
There was a problem hiding this comment.
Probably both the skipIf and the run() method can be put in a common class and all command_v2 tests use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fixing
--helpfor commands in proposal for command line v2.0.Docs: omit
Closes: #7366
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.