New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Conan V2 cli broken help #7394
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
791327d
fix arguments
czoido 96f1ebb
add test
czoido 72f67e5
conditional import of Cli
czoido ced6b4b
workaround for pkgutil api change
czoido 736df13
skip python2
czoido 82574d2
change message
czoido 488d857
dont test --help
czoido 0be481c
remove default value
czoido 7dd15fe
remove CONAN_USER_COMMANDS envvar
czoido File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import unittest | ||
|
||
from conans.client.tools import environment_append, save, six | ||
from conans.test.utils.tools import TestClient | ||
|
||
|
||
@unittest.skipIf(six.PY2, "v2.0: Only testing for Python 3") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably both the skipIf and the run() method can be put in a common class and all command_v2 tests use it. |
||
class CliHelpTest(unittest.TestCase): | ||
|
||
def run(self, *args, **kwargs): | ||
with environment_append({"CONAN_V2_CLI": "1"}): | ||
super(CliHelpTest, self).run(*args, **kwargs) | ||
|
||
def help_command_test(self): | ||
client = TestClient() | ||
|
||
client.run("help") | ||
self.assertIn("Shows help for a specific command", client.out) | ||
|
||
client.run("help search") | ||
self.assertIn("Searches for package recipes whose name contain", client.out) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a Py2.7 thing? If that is the case, I am happy with the check you did in the test to run the test only in Py3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because in 3.5 they changed the return from a tuple to a named tuple for
iter_modules
return value:https://docs.python.org/3.5/library/pkgutil.html#pkgutil.iter_modules
https://docs.python.org/3.6/library/pkgutil.html#pkgutil.iter_modules
Python2 issue is another one.