Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frameworks in qmake generator #7581

Closed

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Qmake generator OSX framework support
Docs: Omit

Close #7564

cc/ @ttencate if you want to check this PR, that would be very helpful.

@memsharded memsharded requested a review from SSE4 August 23, 2020 21:19
@memsharded memsharded added this to the 1.29 milestone Aug 23, 2020
@SSE4
Copy link
Contributor

SSE4 commented Aug 23, 2020

I already did #7579 :(
let's merge PRs together

@memsharded
Copy link
Member Author

ooops, my bad. I hadn't catched up that notification. I'll close my PR.

@memsharded memsharded closed this Aug 23, 2020
@memsharded memsharded deleted the feature/frameworks_qmake branch August 23, 2020 21:34
@ttencate
Copy link
Contributor

I don't know the first thing about OSX so I can't help on either PR, sorry :(

@czoido czoido removed this from the 1.29 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] QMake generator do not handle OSX frameworks
4 participants