-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove arbitrary or unnecessary content from make toolchain #7942
Remove arbitrary or unnecessary content from make toolchain #7942
Conversation
@memsharded please review (I don't have permission to add a reviewer.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid there was some misunderstanding, it seems you went too far.
I meant, all the vars that are not being used at all in the build, like CONAN_TC_ARCH_HOST.
Other vars, they were actually involved in the build, and they were being injected in CONAN_TC_SETUP, right? Then we have at least some evidence that they are not completely broken.
I've restored the specific preprocessor definitions requested. Please name or highlight any other specific flags or definitions which you would like restored. I think it's best for you to choose the list explicitly in this case. |
@memsharded Here are four items related to settings which were removed. Please indicate any of these which should be restored.
|
These should be restored, making sure they are actually being used in the compilation, checking the binary or introducing architecture or cppstd specific code, it depends. |
I have merged it, lets build step by step on the minimalistic toolchain |
From conversation on slack with @memsharded :
This implementation removes everything not necessary to have tests passing on linux and windows (mingw32). I think it is minimalistic, but @memsharded please advise if anything else should be changed.
Changelog: Fix: Simplified MakeToolchain to remove things that were not checked by tests or unused.
Docs: omit
develop
branch, documenting this one.#TAGS: slow