New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check usage f urllib3 #8042
check usage f urllib3 #8042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.25.4 and 1.25.5 contained a bug that was affecting us. New requests 2.25.0 (to be released today) will be compatible with new urllib3 1.26.
OTH, the new pip
resolution algorithm 2020-resolver (should be the default very soon, it says October 2020) won't resolve to the conflicting dependencies, it looks like there is some metadata in the packages. This works for me:
pip install --use-feature=2020-resolver -U -r conans/requirements.txt
It is a bit weird because it should be able to resolve the conflict. The restriction we provide block only two versions (buggy versions).
|
It is the new algorithm, no metadata, https://github.com/psf/requests/blob/0797c61fd541f92f66e409dbf9515ca287af28d2/setup.py#L47 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, @jgsogo do we agree we shouldn't remove these constraints but introduce <1.26
?
pip added |
* check usage f urllib3 * introduce <1.26 constraint for urlib3 Co-authored-by: czoido <mrgalleta@gmail.com>
Changelog: Bugfix: Recent
liburl3
1.26 library updates is breaking the constraints in Conanrequirements.txt
asrequests
2.24 has a limitation forliburl3
. This PR constrainsliburl3
version to be less than 1.26, so it does not break with requests 2.24.Docs: Omit
Close #8041
Note: we might need to backport this to older Conan releases that might also break in prod.
#tags: slow, svn
#revisions: 1