-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conan dependency problem with urllib3 #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib3 1.26.0 has been released, causing a dependency error when installing conan. Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
mtreinish
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I'm not sure of is the pyproject.toml change. But it doesn't hurt since this is just a temporary PR to unblock CI. We should revert this once there is a working combination of urllib3, requests, and conan again.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
urllib3 1.26.0 has been released, causing a dependency error when installing conan. Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
urllib3 1.26.0 has been released, causing a dependency error when installing conan. Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
urllib3 1.26.0 has been released, causing a dependency error when installing conan. Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
urllib3 1.26.0 has been released, causing a dependency error when installing conan. Here I add urllib3 add as a dependency and cosntrainit it <1.26 to avoid this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
urllib3
1.26.0 has been released, causing a dependency when installing conan (coming formrequests
lib).Here I add
urllib3
add as a dependency and constraint it to <1.26 to avoid this problem.Details and comments
The issue has been already reported to
Conan
team by some users: conan-io/conan#8041.Here conan-io/conan#8042 they mention that
requests
lib version 2.25 (to be releasedtodaytomorrow: psf/requests#5654) will be compatible with thisurllib3
1.26. In the meantime we can use this ugly fix.