Improve error message when a folder is not an SCM repo #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Before you would get this: ConanException: Not a valid 'svn' repository Which doesn't help much, especially if you're using "conan create" which may be off in a folder you didn't create. Add the path of the folder to the error message to instead get: ConanException: '/a/b/not_an_svn_repo' is not a valid 'svn' repository
lasote
approved these changes
May 24, 2021
|
Thanks for contributing this! Merging this to be included in next 1.37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Improve error message when a directory doesn't contain a valid repository.
Docs: omit
Before you would get this:
ConanException: Not a valid 'svn' repository
Which doesn't help much, especially if you're using
"conan create" which may be off in a folder you didn't
create.
Add the path of the folder to the error message to instead
get:
ConanException: '/a/b/not_an_svn_repo' is not a valid 'svn' repository