Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain.py #9144

Merged
merged 1 commit into from Jun 23, 2021
Merged

Conversation

blackliner
Copy link
Contributor

@blackliner blackliner commented Jun 23, 2021

Changelog: Feature: Add support for CMAKE_CXX_STANDARD_REQUIRED in CMakeToolchain.
Docs: omit

Should this feature be controllable through a setting?

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it is ok to define it, as it is an "opt-in" defined by the definition of settings.compiler.cppstd, and if it is defined, it can be REQUIRED by cmake, to avoid fallback to previous standards.

@memsharded memsharded added this to the 1.38 milestone Jun 23, 2021
@czoido czoido merged commit 4004088 into conan-io:develop Jun 23, 2021
@blackliner blackliner deleted the blackliner-cxx-standard branch June 23, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants