fix generators_folder relative path to conanfile #9668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
requested changes
Sep 29, 2021
There was a problem hiding this comment.
So, is this superseded by https://github.com/conan-io/conan/pull/9674/files ?
I would say this is breaking if not conditioned to the usage of the layout.
lasote
reviewed
Oct 4, 2021
conans/test/functional/toolchains/cmake/test_v2_cmake_template.py
Outdated
Show resolved
Hide resolved
lasote
reviewed
Oct 4, 2021
| conanfile.folders.set_base_generators(dir_path) | ||
| conanfile.folders.set_base_build(dir_path) | ||
| conanfile.folders.set_base_source(dir_path) | ||
| # FIXME: this is bad, but conanfile.folders.package=xxx is broken atm, cant be used |
There was a problem hiding this comment.
I mean, I don't understand why/what is broken.
lasote
approved these changes
Oct 4, 2021
franramirez688
approved these changes
Oct 4, 2021
yowidin
reviewed
Oct 22, 2021
|
|
||
| pkg_folder = args_to_string([self._conanfile.package_folder.replace("\\", "/")]) | ||
| build_folder = args_to_string([self._conanfile.build_folder]) | ||
| arg_list = ["--install", build_folder, build_config, "--prefix", pkg_folder] |
There was a problem hiding this comment.
The --install command line argument isn't available in earlier versions of the CMake, it was probably introduced only in CMake 3.15. Please consider changing the call back to a build call with the install target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix:
generator_folderwas using thecwdinstead of a relative folder to the conanfile, producing layout errors.Docs: Omit
#tags: slow