define layout folders for package and export-pkg commands #9674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Sep 27, 2021
conan/tools/cmake/cmake.py
Outdated
| build_config = "--config {}".format(bt) if bt and is_multi else "" | ||
|
|
||
| pkg_folder = self._conanfile.package_folder.replace("\\", "/") | ||
| arg_list = ["--install", self._conanfile.build_folder, build_config, "--prefix", pkg_folder] |
There was a problem hiding this comment.
Using the --install feature avoids needing an extra cmake.configure() in package() before cmake.install() to change the CMAKE_INSTALL_PREFIX that was already defined previously, and this allows conan export-pkg to work.
| conanfile.folders.set_base_source(conanfile_folder) | ||
| conanfile.folders.set_base_package(dest_package_folder) | ||
| conanfile.folders.set_base_install(conanfile_folder) | ||
| conanfile.folders.set_base_generators(conanfile_folder) |
There was a problem hiding this comment.
Similar to #9668:
- I need to know the location of the generators_folder.
- I prefer not needing an extra
--build-foldercli argument
| @@ -800,6 +801,7 @@ def package(self, path, build_folder, package_folder, source_folder=None, instal | |||
| conanfile.folders.set_base_source(source_folder) | |||
| conanfile.folders.set_base_package(package_folder) | |||
| conanfile.folders.set_base_install(install_folder) | |||
| conanfile.folders.set_base_generators(conanfile_dir) | |||
There was a problem hiding this comment.
Not a big deal, if conan package is removed in Conan 2.0, but this also relies on the conanfile location, not an extra --build-folder location.
memsharded
changed the title
|
Merged and unified in #9668, as it is almost the same issue. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Command
conan packagenow works for newlayout()with generators folder.Docs: Omit
conan export-pkgis still brokenpackage,export-pkgflows.