Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to grunt 0.4, and node 0.10 GH-6 #8

Merged
merged 13 commits into from
Apr 7, 2013

Conversation

joneshf
Copy link
Contributor

@joneshf joneshf commented Apr 6, 2013

So I don't have push access to the original repo. But this should be for issue 6: #6

I had a concern though, we were using helpers.options in the task. Is that necessary for something? It seems that this.options provides the task with the options defined in Gruntfile.js. Or is there something else that is going on? I removed the dependency for grunt-lib-contrib if we don't need that helper anymore. If so, I can add that back in. I also tried to clean up the transpile function a bit, so that it is easier to read and maintain. Hopefully that should make adding additional languages easier.

Updated to node 0.10.x. The tests pass on my machine with npm test, dunno about travis yet though. I lied, travis is all good.

@mehcode
Copy link
Contributor

mehcode commented Apr 7, 2013

I had a concern though, we were using helpers.options in the task. Is that necessary for something? It seems that this.options provides the task with the options defined in Gruntfile.js. Or is there something else that is going on? I removed the dependency for grunt-lib-contrib if we don't need that helper anymore.

It looks like helpers.options and this.options are the same thing. It seems grunt moved it from the contrib lib to core when 0.4 was released (helpers.options isn't in grunt-lib-contrib anymore as well).


Great stuff! Thanks for the work.

mehcode added a commit that referenced this pull request Apr 7, 2013
Update to grunt 0.4, and node 0.10 GH-6
@mehcode mehcode merged commit df8fdbc into concordusapps:master Apr 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants