Update to grunt 0.4, and node 0.10 GH-6 #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I don't have push access to the original repo. But this should be for issue 6: #6
I had a concern though, we were using
helpers.options
in the task. Is that necessary for something? It seems thatthis.options
provides the task with the options defined inGruntfile.js
. Or is there something else that is going on? I removed the dependency forgrunt-lib-contrib
if we don't need that helper anymore. If so, I can add that back in. I also tried to clean up the transpile function a bit, so that it is easier to read and maintain. Hopefully that should make adding additional languages easier.Updated to node 0.10.x. The tests pass on my machine with
npm test
, dunno about travis yet though. I lied, travis is all good.