Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tls.yml to not enable mTLS on the ATC #234

Merged
merged 1 commit into from
May 4, 2021
Merged

Update tls.yml to not enable mTLS on the ATC #234

merged 1 commit into from
May 4, 2021

Conversation

davewalter
Copy link
Contributor

Per issue #233, this PR updates the tls.yml cluster ops-file to not include the CA certificate in the ATC configuration as this will enable mTLS as of v7.0.0. It also includes a new mtls.yml ops-file for users who do want to enable mTLS.

- providing the CA certificate enables mTLS as of v7.0.0
- include a new ops-file called mtls.yml to enable mTLS if required

Co-authored-by: Jaskanwal Pawar <jpawar@vmware.com>
Signed-off-by: Dave Walter <walterda@vmware.com>
Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - shouldn't break anyone's flow since it continues to use the atc_tls var. No new vars are introduced or needed to make this work.

@taylorsilva taylorsilva merged commit 2835f5d into concourse:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants