Dashboard: anchor links on team groups

#1554 Signed-off-by: Gabriel Dumitrescu <gdumitrescu@pivotal.io>
concourse · Sep 11, 2017 · cd954b9 · cd954b9
1 parent 9f4d4f6
commit cd954b9
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 14 deletions.
diff --git a/web/acceptance/spec/dashboard_spec.rb b/web/acceptance/spec/dashboard_spec.rb
@@ -196,6 +196,12 @@
     end
   end
 
+  it 'anchors URL links on team groups' do
+    login
+    visit dash_route('/dashboard')
+    expect(page).to have_css('.dashboard-team-group', id: team_name)
+  end
+
   private
 
   def login

diff --git a/web/assets/css/dashboard.less b/web/assets/css/dashboard.less
@@ -1,12 +1,19 @@
 .dashboard {
-  padding: 45px 25px 0 45px;
+  padding: 0 25px 0 45px;
+}
+
+.dashboard-team-group {
+  padding-top: 55px;
+
+  &:first-of-type {
+    padding-top: 45px;
+  }
 }
 
 .dashboard-team-pipelines {
   display: flex;
   flex-flow: row wrap;
   justify-content: space-between;
-  margin-bottom: 55px;
 }
 
 .dashboard-team-name {

diff --git a/web/bindata.go b/web/bindata.go
diff --git a/web/elm/src/Dashboard.elm b/web/elm/src/Dashboard.elm
@@ -8,7 +8,7 @@ import Concourse.Pipeline
 import Date exposing (Date)
 import Dict exposing (Dict)
 import Html exposing (Html)
-import Html.Attributes exposing (class, classList, href, src)
+import Html.Attributes exposing (class, classList, id, href, src)
 import RemoteData
 import Task exposing (Task)
 import Time exposing (Time)
@@ -162,10 +162,9 @@ type alias PipelineState =
 
 viewGroup : Maybe Time -> String -> List PipelineState -> Html msg
 viewGroup now teamName pipelines =
-    Html.div [ class "dashboard-team-group" ]
+    Html.div [ id teamName, class "dashboard-team-group" ]
         [ Html.div [ class "dashboard-team-name" ]
-            [ Html.text teamName
-            ]
+            [ Html.text teamName ]
         , Html.div [ class "dashboard-team-pipelines" ]
             (List.map (viewPipeline now) pipelines)
         ]