-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: task images should be specified as resources #252
Comments
Hi there! We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created. The current status is as follows:
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes. |
+1 to following on with https://www.pivotaltracker.com/n/projects/1059262/stories/111911313 when possible. It seems like the best way to get the benefit of keeping credentials in the pipeline, and letting task.yml's be flexible. And congrats on 1.0!!!!!! |
Hello again! All stories related to this issue have been accepted, so I'm going to automatically close this issue. At the time of writing, the following stories have been accepted:
If you feel there is still more to be done, or if you have any questions, leave a comment and we'll reopen if necessary! |
+1. Found this as I tried to use private Docker Hub repo in task yml config without hardcoding credentials. For pipeline ymls I use Is this proposal integrated into 1.2.0 or some future release? |
Perhaps support for |
Submodule src/github.com/concourse/atc 653ee31ed..227912ed0: > remove go 1.11 module files Submodule src/github.com/concourse/fly b3de00876..41406ef24: > Merge pull request #252 from edtan/validate-creds-on-sp Submodule src/github.com/concourse/go-concourse 013e875..e2bf797: > Merge pull request #15 from edtan/validate-creds-on-sp Submodule src/github.com/concourse/web 83ffe3e3d..d26aa490b: > fix a couple minor alignment issues
The goal of this proposal is to solve the following problems:
Concrete proposal:
image
in tasks to refer to a resource description, rather than a URI string. (The old URI string would be still supported for a period of time, for backwards-compatibility.)image
by pointing to their own resource.The intent of 1) is to keep task config files self-contained, so that
fly execute
and such still work.The intent of 2) is to support configuring resources with credentials in a pipeline, so that credentials don't have to be hardcoded into a task config.
I'm not wild about 2) as it introduces the possibility of the pipeline config specifying an entirely different image than is specified in the task config. It also doesn't cover running
fly execute
with credentials.Anyway, assuming those two changes, task configs would look something like:
atc-go.yml
(using public image)Here's an example of overriding it with a private image in a pipeline:
Another option instead of 2) would be to introduce some sort of templating, but that'd take some thinking since right now all templating is done client-side (and I quite like it that way).
Issues this is relevant to:
The text was updated successfully, but these errors were encountered: