Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-level Parameters #302

Closed
nebhale opened this issue Feb 28, 2016 · 2 comments
Closed

Multi-level Parameters #302

nebhale opened this issue Feb 28, 2016 · 2 comments
Labels

Comments

@nebhale
Copy link

nebhale commented Feb 28, 2016

Currently the params configuration element only allows a single level object depth. In attempt to support Slack Message Attachments, it'd be great if we could have arbitrarily deep configuration objects.

Having this ability results in messages with a bit more flash:

screen shot 2016-02-28 at 10 07 32

instead of

screen shot 2016-02-28 at 10 07 41

Currently a configuration like

---
jobs:
- name: some-job
  plan:
  - put: slack-alert
    params:
      attachments:
      - color: good
        fallback: $BUILD_PIPELINE_NAME #$BUILD_NAME has been deployed: $ATC_EXTERNAL_URL/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME
        text: $BUILD_PIPELINE_NAME <$ATC_EXTERNAL_URL/pipelines/$BUILD_PIPELINE_NAME/jobs/$BUILD_JOB_NAME/builds/$BUILD_NAME|#$BUILD_NAME> has been deployed

results in

error: Unexpected Response
Status: 500 Internal Server Error
Body:
failed to save config: json: unsupported type: map[interface {}]interface {}
@concourse-bot
Copy link
Collaborator

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #114640207 Support multi-level parameters for resources

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@concourse-bot
Copy link
Collaborator

Hello again!

All stories related to this issue have been accepted, so I'm going to automatically close this issue.

At the time of writing, the following stories have been accepted:

  • #114640207 Support multi-level parameters for resources

If you feel there is still more to be done, or if you have any questions, leave a comment and we'll reopen if necessary!

vito added a commit that referenced this issue Mar 31, 2017
Submodule src/github.com/onsi/ginkgo 120efcfd..13c94a13:
  > v1.3.0
  > Remove the spec_iterator.test binary (#336)
  > Shared queue implementation for parallel tests
  > Revert "Don't colorize output by default if not writing to a TTY (#328)" (#331)
  > Don't colorize output by default if not writing to a TTY (#328)
  > Use SVG badge for build status (#330)
  > Add the ability to use ./... to recursively test directories (#319)
  > Include captured output from failed tests into JUnit (#318)
  > Aggregate flaked specs (#316)
  > Add colours for Windows in suite-runner & watch (#312)
  > Fix tests for single node machine (#311)
  > Add ability to specify a custom bootstrap file (#302)
  > Revert "remove -i in invocations of go test.  fixes #305"
  > Update .travis.yml
  > fix imports for generate command (#279)
  > Merge branch 'koron-windows-colorise'
  > remove -i in invocations of go test.  fixes #305
  > remove unnecessary variable
  > backfill GinkgoRandomSeed test
  > Expose the random seed via GinkgoRandomSeed() (#293)
  > Include flake count in test summary (#291)
  > #287 Ensure Logf/Skipf insert newline characters (#288)
  > Add package path prefix to compilation output path only if missing (#284)
vito added a commit that referenced this issue Apr 10, 2017
Submodule src/github.com/onsi/ginkgo 120efcfd..f40a49d8:
  > fix flaky test by, you know, not relying on obscure go internals
  > update .travis.yml to get latest patch releases
  > fix failing go 1.5 tests
  > ensure tests pass on Go 1.8.1
  > v1.3.1: Actually change the CLI version
  > print location of test suite that failed to report back (#339)
  > v1.3.0
  > Remove the spec_iterator.test binary (#336)
  > Shared queue implementation for parallel tests
  > Revert "Don't colorize output by default if not writing to a TTY (#328)" (#331)
  > Don't colorize output by default if not writing to a TTY (#328)
  > Use SVG badge for build status (#330)
  > Add the ability to use ./... to recursively test directories (#319)
  > Include captured output from failed tests into JUnit (#318)
  > Aggregate flaked specs (#316)
  > Add colours for Windows in suite-runner & watch (#312)
  > Fix tests for single node machine (#311)
  > Add ability to specify a custom bootstrap file (#302)
  > Revert "remove -i in invocations of go test.  fixes #305"
  > Update .travis.yml
  > fix imports for generate command (#279)
  > Merge branch 'koron-windows-colorise'
  > remove -i in invocations of go test.  fixes #305
  > remove unnecessary variable
  > backfill GinkgoRandomSeed test
  > Expose the random seed via GinkgoRandomSeed() (#293)
  > Include flake count in test summary (#291)
  > #287 Ensure Logf/Skipf insert newline characters (#288)
  > Add package path prefix to compilation output path only if missing (#284)
vito added a commit that referenced this issue Sep 10, 2018
Submodule src/github.com/concourse/atc 05e5bd786..3379392b9:
  > Merge pull request #302 from concourse/gc-concurrency-removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants