Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: added "new version" tooltip for resource first occurrences #3136

Merged
merged 7 commits into from Jan 28, 2019

Conversation

@pivotal-jamie-klassen
Copy link
Contributor

pivotal-jamie-klassen commented Jan 23, 2019

fixes #3093

@pivotal-jamie-klassen pivotal-jamie-klassen force-pushed the issue/3093 branch 2 times, most recently from f4c4ebd to 32bc1c7 Jan 23, 2019
@vito

This comment has been minimized.

Copy link
Member

vito commented Jan 24, 2019

@pivotal-jamie-klassen d'oh, this needs to be rebased now

pivotal-jamie-klassen and others added 5 commits Jan 23, 2019
- Also pulled out Build Models to their own file

#3093

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: James Cooper <jcooper@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: Saman Alvi <salvi@pivotal.io>
…hem that way

Signed-off-by: James Cooper <jcooper@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: Saman Alvi <salvi@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: Saman Alvi <salvi@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: Saman Alvi <salvi@pivotal.io>
…3093

Signed-off-by: James Cooper <jcooper@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Copy link
Member

vito left a comment

Just tried it! This works great but I feel like there could be some more UX polish.

screenshot 2019-01-27 at 3 29 55 am

  • The tooltip sticks around as long as my mouse is moving over it, so it can get in the way if I'm trying to click something it's covering.
  • Minor nit: the text is selectable, which feels kinda weird for some reason. (It'd end up in the text content if they did Ctrl+A Ctrl+C I guess. 🤷‍♂️ )
  • It's not super clear what the tooltip is associated to; it just sort of appears out of nowhere if I happen to be moving my mouse around there. Which is easy to do on the path to the individal build links. Maybe a directional arrow thingy at the bottom left corner would help?
  • Stealing notes from GitHub while I'm reviewing this, I just noticed their tooltips have a brief delay before they appear. So they never felt like they got in the way, even though they're actually quite large.

For reference:

screenshot 2019-01-27 at 3 35 41 am

#3093

Signed-off-by: Bohan Chen <bochen@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
@vito
vito approved these changes Jan 28, 2019
Copy link
Member

vito left a comment

much better!

screenshot from 2019-01-28 16-21-43

@vito vito merged commit 37c3124 into master Jan 28, 2019
5 checks passed
5 checks passed
DCO DCO
Details
WIP Ready for review
Details
concourse-ci/testflight Concourse CI build success
Details
concourse-ci/unit Concourse CI build success
Details
concourse-ci/watsjs Concourse CI build success
Details
@vito vito deleted the issue/3093 branch Jan 28, 2019
@vito vito added this to the v5.0.0 milestone Jan 28, 2019
@vito vito added the enhancement label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.