web: added "new version" tooltip for resource first occurrences #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieklassen
force-pushed
the
issue/3093
branch
2 times, most recently
from
f4c4ebd
to
32bc1c7
Compare
|
@pivotal-jamie-klassen d'oh, this needs to be rebased now |
- Also pulled out Build Models to their own file #3093 Signed-off-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: James Cooper <jcooper@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: Saman Alvi <salvi@pivotal.io>
…hem that way Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: Saman Alvi <salvi@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: Saman Alvi <salvi@pivotal.io>
Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: Saman Alvi <salvi@pivotal.io>
jamieklassen
force-pushed
the
issue/3093
branch
from
32bc1c7
to
d37af4e
Compare
…3093 Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
vito
requested changes
Jan 27, 2019
There was a problem hiding this comment.
Just tried it! This works great but I feel like there could be some more UX polish.
- The tooltip sticks around as long as my mouse is moving over it, so it can get in the way if I'm trying to click something it's covering.
- Minor nit: the text is selectable, which feels kinda weird for some reason. (It'd end up in the text content if they did Ctrl+A Ctrl+C I guess. 🤷♂️ )
- It's not super clear what the tooltip is associated to; it just sort of appears out of nowhere if I happen to be moving my mouse around there. Which is easy to do on the path to the individal build links. Maybe a directional arrow thingy at the bottom left corner would help?
- Stealing notes from GitHub while I'm reviewing this, I just noticed their tooltips have a brief delay before they appear. So they never felt like they got in the way, even though they're actually quite large.
For reference:
#3093 Signed-off-by: Bohan Chen <bochen@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
vito
added
the
release/documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3093