k8s/topgun: update prometheus dependencies and disable worker #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the prometheus chart recently updated itself to have `kube-state-metrics` being a subchart, rather than embedded on itself. because of that, we need to first fetch its dependencies, and then later on, install it. here I also got rid of the Concourse worker that was being deployed - this is possible because nowadays we offer the ability to do so (something you couldn't before), and because the worker is unecessary for this case. Signed-off-by: Ciro S. Costa <cscosta@pivotal.io>
|
I just realized this is very related to concourse/ci#285. IMO both coexist: I don't think that because this solves the point of having to |
taylorsilva
approved these changes
May 11, 2020
taylorsilva
added
the
release/no-impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
With
stable/prometheusgoing from havingkube-state-metricsembedded in its set of templates to a separate dependency,k8s-topgunstarted failing:Without this PR, we can't have
k8s-topgunrunning without having the version ofhelm/chartspinned to an old commit, which would force us to have that commit hardcoded in the release branches, as well as the main pipeline.What is this PR trying to accomplish?
It tries to make the installation of
prometheuspossible regardless of how its dependencies are set up (either throughrequirements.yaml- the new way of doing thing -, or the old one - embedded).How does it accomplish that?
It does so by running
helm dependency updatebefore runninghelm install.Given that such command will not fail in case of
requirements.yamlnot existing (which would be true for older versions of thehelm/chartsrepo), it's safe to always do it.Reviewer Checklist
and Helm packaging; otherwise, ignored for the integration tests (for example, if they are Garden configs that are not displayed in the
--helptext).