Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: archived pipelines UI beyond Dashboard #5760

Merged
merged 5 commits into from
Jun 22, 2020
Merged

web: archived pipelines UI beyond Dashboard #5760

merged 5 commits into from
Jun 22, 2020

Conversation

aoldershaw
Copy link
Contributor

@aoldershaw aoldershaw commented Jun 12, 2020 •
edited by zoetian
Loading

What does this PR accomplish?

Bug Fix | Feature | Documentation

Changes proposed by this PR:

  • Fix search bar appearance on small screens and on Firefox
  • Remove access to buttons in Pipeline, Job, Build, and Resource views for archived pipelines

Notes to reviewer:

  • Search bar appearance issues:

    • [master] on small screens, looks like:

      Screen Shot 2020-06-12 at 2 08 30 PM

    • [master] on Firefox, looks like:

      Screen Shot 2020-06-12 at 2 14 39 PM
  • To test removal of buttons for archived pipelines:
    1. fly archive-pipeline a pipeline with resources and builds
    2. Navigate to it using the sidebar
    3. Check out the various screens for that pipeline (Pipeline, Job, Build, and Resource) - you shouldn't be able to perform any actions
    • For Resource, you should test it with and without a pinned version, since there are different buttons available in each case

Contributor Checklist

Reviewer Checklist

  • Code reviewed
  • Tests reviewed
  • Documentation reviewed
  • Release notes reviewed
  • PR acceptance performed
  • New config flags added? Ensure that they are added to the
    BOSH and
    Helm packaging; otherwise, ignored for
    the integration
    tests
    (for example, if they are Garden configs that are not displayed in the
    --help text).

@aoldershaw aoldershaw requested a review from a team June 12, 2020 18:18
This was referenced Jun 12, 2020
Closed
Closed
@zoetian zoetian self-assigned this Jun 15, 2020
@scottietremendous scottietremendous added this to the v6.4.0 milestone Jun 15, 2020
@aoldershaw
web: behaviour: fix searchbar appearance
1d7628c 
Fixes a couple existing problems:

1. On firefox, searchbar appeared shifted
2. On mobile, input bar shrinks when dropdown open

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw
web: behaviour: pipeline topbar, archived is not paused
b7f8c4e 
* Don't use the blue "paused" background for archived pipelines
* Don't render the pause toggle button

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw
web: behaviour: actions disallowed on job header
3193a3b 
* Hide play/pause button
* Hide trigger build button

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw
web: behaviour: actions disallowed on build header
501a673 
* No buttons on header

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw
web: behaviour: archived resource view
5797e83 
* Don't display check status + check button
* Don't display last checked time
* Don't display edit pinned comment button
* Pin icon for pinned version is not clickable or hoverable
* Don't display pin and enable/disable buttons in versions list

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw aoldershaw changed the title web: archived pipelines UI web: archived pipelines UI beyond Dashboard Jun 16, 2020
zoetian
zoetian approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@zoetian zoetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

@aoldershaw aoldershaw merged commit 27b4b96 into master Jun 22, 2020
@aoldershaw aoldershaw deleted the archived-ui branch June 22, 2020 21:07
@xtreme-sameer-vohra xtreme-sameer-vohra added the release/undocumented This didn't warrant being documented or put in release notes. label Jul 10, 2020
@xtreme-sameer-vohra
Copy link
Contributor

Hey @aoldershaw
Assuming this is the first introduction of the archived view and navigating to it is simpler to that of a non archived pipeline so there isn't anything to document in the release notes or concourse/docs.

@aoldershaw
Copy link
Contributor Author

@xtreme-sameer-vohra yep, nothing to really document here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetian zoetian zoetian approved these changes

Assignees

@zoetian zoetian

Labels
archive-pipelines enhancement release/undocumented This didn't warrant being documented or put in release notes.
Projects
None yet
Milestone
v6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aoldershaw @xtreme-sameer-vohra @zoetian @scottietremendous