Allow configuring login and query timeouts for Vault #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… managers). Signed-off-by: Chao Li <chaol@vmware.com>
Signed-off-by: Chao Li <chaol@vmware.com>
evanchaoli
force-pushed
the
study-vault
branch
from
e78abcc
to
9266a95
Compare
evanchaoli
force-pushed
the
study-vault
branch
from
a94b3b7
to
7404a19
Compare
aoldershaw
requested changes
Jan 5, 2021
There was a problem hiding this comment.
Hey @evanchaoli, really sorry about the slow review! I was on vacation for much of December, so haven't had a chance to look at this until now
Signed-off-by: Chao Li <chaol@vmware.com>
Signed-off-by: Chao Li <chaol@vmware.com>
evanchaoli
force-pushed
the
study-vault
branch
from
2e4b4c7
to
178b8cc
Compare
evanchaoli
changed the title
aoldershaw
requested changes
Jan 11, 2021
Signed-off-by: Chao Li <chaol@vmware.com>
11 tasks
|
@aoldershaw I backport this PR to 6.7.x with #6413 because we keep seeing "missing client token" errors on our prod cluster, so I want to solve the problem in 6.7.3. Please also help review #6413. |
aoldershaw
approved these changes
Jan 12, 2021
aoldershaw
changed the title
aoldershaw
added a commit
to concourse/concourse-bosh-release
that referenced
this pull request
Jan 14, 2021
from concourse/concourse#6362 Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
This was referenced Jan 14, 2021
aoldershaw
added a commit
that referenced
this pull request
Jan 14, 2021
Backport #6362 to 6.7.x: handle slow Vault
6 tasks
aoldershaw
added a commit
to concourse/concourse-bosh-release
that referenced
this pull request
Jan 21, 2021
from concourse/concourse#6362 Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
aoldershaw
changed the title
aoldershaw
added
the
release/undocumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
closes #6347 .
Changes proposed by this PR:
VarSourcePool, add a helper classinPoolSecretto wait for Vault to login, so thatvarSourcePool.FindOrCreatewon't be blocked.Notes to reviewer:
The first commit is for your initial review from the design perspective. Code is not cleaned up yet, and tests not added yet.
EDIT: Now it's ready for review. Code cleaned up, tests added.
Release Note
CONCOURSE_VAULT_LOGIN_TIMEOUTandCONCOURSE_VAULT_QUERY_TIMEOUTrespectively60sContributor Checklist
Reviewer Checklist
BOSH and
Helm packaging; otherwise, ignored for
the integration
tests
(for example, if they are Garden configs that are not displayed in the
--helptext).