Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize fly windows tests #6450

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Optimize fly windows tests #6450

merged 4 commits into from
Jan 20, 2021

Conversation

aoldershaw
Copy link
Contributor

What does this PR accomplish?

Bug Fix | Feature | Documentation

Backport of #6317 and #6320 for release/6.7.x. Now that we've bumped Dex, the fly windows tests are super slow and flaky.

Changes proposed by this PR:

Notes to reviewer:

Contributor Checklist

Reviewer Checklist

  • Code reviewed
  • Tests reviewed
  • Documentation reviewed
  • Release notes reviewed
  • PR acceptance performed
  • New config flags added? Ensure that they are added to the
    BOSH and
    Helm packaging; otherwise, ignored for
    the integration
    tests

    (for example, if they are Garden configs that are not displayed in the
    --help text).

vito and others added 3 commits January 20, 2021 10:32
this massively slows down the suite; just fake out the version number
via an env var instead

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Eventually is the path to darkness

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Windows can't run this unless it has .exe in the filename

:tableflip:

the Chmod change here doesn't really matter...but it feels nicer.

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Co-authored-by: Muntasir Chowdhury <mchowdhury@pivotal.io>
Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@aoldershaw aoldershaw merged commit 25dab50 into release/6.7.x Jan 20, 2021
@aoldershaw aoldershaw deleted the fly-windows-optim branch January 20, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants