Skip Vault tests in Topgun #6481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #6115 was merged, all the Bosh Topgun tests exercising Vault started failing. This is not due to the Vault integration being broken (well, not really) - Bosh topgun is just using such an old (custom) version of Vault that is no longer compatible I gather. Since we're going to end up replacing all these tests shortly with a new test suite (introduced in #6479), let's just skip these Vault tests for now Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Bug Fix | Feature | Documentation
After #6115 was merged, all the Bosh Topgun tests exercising Vault
started failing. This is not due to the Vault integration being broken
(well, not really) - Bosh topgun is just using such an old (custom)
version of Vault that is no longer compatible I gather.
Since we're going to end up replacing all these tests shortly with a new
test suite (introduced in #6479), let's just skip these Vault tests for
now
Changes proposed by this PR:
Notes to reviewer:
Contributor Checklist
Reviewer Checklist
BOSH and
Helm packaging; otherwise, ignored for
the integration
tests
(for example, if they are Garden configs that are not displayed in the
--helptext).