Ignore cached input from volume-locality's consideration #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanchaoli
force-pushed
the
no-input-strategy
branch
from
7bcc6a1
to
b2d5d35
Compare
evanchaoli
force-pushed
the
no-input-strategy
branch
2 times, most recently
from
928f2e0
to
260b0ec
Compare
1 task
evanchaoli
force-pushed
the
no-input-strategy
branch
3 times, most recently
from
d4d6b1d
to
084ff5c
Compare
Signed-off-by: Evan <chaol@vmware.com>
evanchaoli
force-pushed
the
no-input-strategy
branch
from
084ff5c
to
b8427af
Compare
evanchaoli
changed the title
evanchaoli
changed the title
|
@xtremerui I have reduced scope of this PR to focus on "ignore cached input from volume-locality's consideration". Hope that helps quicker review. |
1 task
xtremerui
reviewed
Feb 17, 2022
atc/exec/put_step_test.go
Outdated
| } | ||
| }) | ||
|
|
||
| It("runs with specified inputs", func() { |
There was a problem hiding this comment.
How is a specified input related to cache?
There was a problem hiding this comment.
I think this is a typo. Goal of this test is to make sure when only input is from cache, container spec is well populated, FromCache should be true.
Signed-off-by: Evan <chaol@vmware.com>
|
In acceptance test, the task |
xtremerui
approved these changes
Feb 22, 2022
xtremerui
added
the
release/documented
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Closes #8070
volume-locality'sOrder()Notes to reviewer
Release Note
EnableCacheStreamedVolumeis enabled and container placement strategy isvolume-locality, asgetstep may not fetch a resource if the resource is found in cache, following step containers may all be placed to the worker where cached resource is found. That worker might be overloaded when there are other workers available. This PR fixes the problem.