Support a way to skip implied get after put. #8492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #3299
Notes to reviewer
There have been much such requests, and I fully understood why implied
get
is needed in order to keep a resource fresh.But we may also honor reality. There are a lot of put only resources running in pipelines, mostly about notifications, like
put: email
,put: slack
, etc. Impliedget
just run an empty container, and plug nestedimage-check
+image-get
. We have noticed that Intermittently impliedget
happened to be placed on a busy worker thus stuck for some time, but they didn't do anything, which hurts stability of build execution.Adding such an option to opt-out implied
get
willThe other reason I reopen the issue is that, Concourse proposed other approaches to solve the problem, but now those approaches seem to be no ETA anymore.
If you agree to merge this PR, I can update docs as well.
Release Note
no_get
option toput
step to skip impliedget
. For example: