-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fly excludes Mac metadata when uploading local inputs #8939
Fly excludes Mac metadata when uploading local inputs #8939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for having the fix in a separate commit to make reviewing easier. I'll figure out this CI and CodeQL stuff.
One thing I'm also not sure about is if our current scripts will run the tests in go-archive or if we'll have to update CI. Going to look into that.
Looks like all the unit tests should get run: https://github.com/concourse/ci/blob/883ba8faf5db4ae8af582143cd7d54f0a59e958b/tasks/scripts/unit#L26 |
I'll note that the code that is changed in |
@taylorsilva any updates here? I'm not able to see the concourse output of the failed ci runs. |
@selzoc yes! Could you rebase on master please? We had to fix some stuff in the integration test suite. Once you rebase and CI runs again I'll merge the PR. Thanks for pinging btw Edit: Forgot I could rebase your PR myself! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need CI to pass
af968bb
to
a610f2c
Compare
Ah there's an issue with
|
OK I pushed a fix for that integration failure - it's a bit weird to have inlined |
From the most recent run:
and above that
|
This is in preparation for making a modification to it in relation to concourse#8916. The original repo has been archived for several years. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
On recent MacOS machines, tar files created (i.e. from `fly execute` with a local resource) include files prefixed by `._`. As a result, once you transfer this tar file to a Linux system and untar, these files may interfere with jobs. This flag will prevent that from happening. Fixes concourse#8916 See cloudfoundry/bosh-utils@f79167b for a similar fix to the `bosh` cli. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
same as the one's in the root of concourse/concourse Signed-off-by: Taylor Silva <dev@taydev.net>
This satisfies https://github.com/vito/houdini Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
Signed-off-by: Taylor Silva <dev@taydev.net>
5caea2a
to
a1f40ff
Compare
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Thanks for the initial push making this PR happen @selzoc |
Thanks for the follow-through @taylorsilva ! |
Changes proposed by this PR
On recent MacOS machines, tar files created (i.e. from
fly execute
with a local resource) include files prefixed by._
.As a result, once you transfer this tar file to a Linux system and untar, these files may interfere with jobs. This flag will prevent that from happening.
closes #8916
Release Note
fly execute
no longer includes MacOS extended file attributes when uploading local inputs