Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy v6.1.0 #134

Merged
merged 10 commits into from
May 9, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • requests
  • arm_pyart
  • matplotlib
  • dask
  • pyinstaller
  • pytest
  • extension-helpers

Packages found in the meta.yaml but not found by source code inspection:

  • importlib-metadata

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8953961122 - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mwcraig
Copy link
Contributor

mwcraig commented May 5, 2024

I'm not sure this will correctly build until conda-forge builds out support for numpy 2, since the build requirements now include numpy>=2.0.0rc1. I've updated the minimum python version and the minimum IERS data version for now.

@mwcraig
Copy link
Contributor

mwcraig commented May 5, 2024

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits May 5, 2024 15:53
@mwcraig
Copy link
Contributor

mwcraig commented May 5, 2024

@conda-forge-admin please rerender

@mwcraig
Copy link
Contributor

mwcraig commented May 5, 2024

Confirmed that numpy rc1 isn't working yet...

@astrofrog
Copy link
Contributor

We could just patch pyproject in the recipe? Isn't this going to be an issue for all packages which are following the numpy recommendations btw?

@pllim
Copy link
Contributor

pllim commented May 6, 2024

Blocked by this?

@neutrinoceros
Copy link

Not sure it's a blocker; My understanding (from conda-forge/conda-forge.github.io#1997) is that numpy 2.0 compat will happen through an automated migration, so it should indeed be okay to just patch pyproject.toml here and ignore numpy 2.0 until further notice.

@mwcraig
Copy link
Contributor

mwcraig commented May 7, 2024

I'll update this first thing tomorrow...

@mwcraig
Copy link
Contributor

mwcraig commented May 8, 2024

@conda-forge-admin please rerender

@mwcraig
Copy link
Contributor

mwcraig commented May 8, 2024

@astrofrog @neutrinoceros -- would you mind giving this a quick look before it gets merged?

recipe/pyproject.toml.patch Outdated Show resolved Hide resolved
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW LGTM TYVM

recipe/meta.yaml Outdated
@@ -41,9 +44,9 @@ requirements:
run:
- python
- {{ pin_compatible("numpy") }}
- numpy <2
- numpy >1.23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is redundant now and pin_compatible("numpy") should be sufficient (even if it wasn't redundant, the constraint is incorrect: it should be >=1.23)

xref https://conda-forge.org/docs/maintainer/knowledge_base/#building-against-numpy

@mwcraig mwcraig merged commit aeb69b3 into conda-forge:main May 9, 2024
20 checks passed
@mwcraig
Copy link
Contributor

mwcraig commented May 9, 2024

Thanks @neutrinoceros and @pllim for reviewing!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 6.1.0_h68fe8d branch May 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants