Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH old smithy not compatible with new conda-build #621

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Dec 20, 2023

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

xref: conda-forge/conda-smithy#1816

@beckermr beckermr requested a review from a team as a code owner December 20, 2023 21:08
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mbargull
Copy link
Member

xref: conda/conda-build#5125

@beckermr
Copy link
Member Author

diff:

================================================================================
================================================================================
noarch
noarch::conda-smithy-3.30.1-pyhd8ed1ab_0.conda
-    "conda-build >=3.18.3",
+    "conda-build >=3.18.3,<3.28.2.0a0",

@beckermr beckermr merged commit 8ba6004 into conda-forge:main Dec 20, 2023
2 of 4 checks passed
@beckermr beckermr deleted the beckermr-patch-1 branch December 20, 2023 21:36
@beckermr
Copy link
Member Author

Well we should patch all copies of smithy.

@jakirkham
Copy link
Member

Does that mean this patch is not sufficient? If so, should we raise an issue to track?

@mbargull
Copy link
Member

Does that mean this patch is not sufficient? If so, should we raise an issue to track?

#622

@jakirkham
Copy link
Member

Ah ok. Thanks Marcel! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants