Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use noarch: python for Python packages #144

Merged
merged 16 commits into from
Jan 19, 2024
Merged

Use noarch: python for Python packages #144

merged 16 commits into from
Jan 19, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Oct 24, 2023 •
edited
Loading

Closes #128

As the XGBoost Python packages are pure Python (using ctypes to interact with the libxgboost library), there is no need to build these for every Python version and architecture. So simply mark these as noarch: python to get the minimum needed builds and move on.

Checklist

@hcho3 @jakirkham
Use noarch: python for Python packages
d46dcf7 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@hcho3 hcho3 marked this pull request as draft October 24, 2023 04:05
@hcho3
Copy link
Contributor Author

hcho3 commented Oct 24, 2023

@conda-forge-admin, please rerender

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Merge conda-forge/main into hcho3/use_noarch
03c5352
@jakirkham
Drop _ between py and h
19444db 
Other `noarch: python` packages typically don't have this extra `_`. So
drop it to make the `build/string` more consistent with other `noarch:
python` packages.
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/7221056343.

@xhochy
Copy link
Member

xhochy commented Dec 15, 2023

The errors could be better explained by switching to conda-build here.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@xhochy
Copy link
Member

xhochy commented Dec 16, 2023

Found the issue in the logs: Unsatisfiable dependencies for platform linux-64. It tries to build the noarch packages on the build_platform but in the cross-compile setting we don't have the native packages available for that yet.

@xhochy
Copy link
Member

xhochy commented Dec 16, 2023

This can be fixed by:

  • Switch dependencies of the noarch packages from exact=True to x.x.x
  • Skip them except for linux-64

@jakirkham
Copy link
Member

Thanks Uwe! 🙏

Was wondering if that might be the case

Have done the first step of relaxing the pin of libxgboost. Not sure if we will need to do this elsewhere or not

Think we may need to skip other platforms as you suggest (and maybe other CUDA versions), but want to see how things behave with the first change before changing this

@xhochy
Copy link
Member

xhochy commented Dec 17, 2023

@conda-forge-admin please rerender

@jakirkham jakirkham marked this pull request as ready for review December 20, 2023 06:15
@jakirkham
Copy link
Member

Looks like we are seeing the same install error on CI

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package conda-forge-ci-setup-4.3.1-py310h84be057_100 requires conda >=23.9, but none of the providers can be installed

jakirkham
jakirkham reviewed Dec 20, 2023
View reviewed changes
conda-forge.yml Outdated Show resolved Hide resolved
@jakirkham
Use mamba to install
3012066 
Per @jaimergp 's suggestion
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/7282436053.

@jakirkham
Copy link
Member

The re-rendering bot is having an issue related to the recent conda-build release ( conda/conda-build#5125 ). There's already some work to pin things down in conda-forge ( conda-forge/conda-forge-repodata-patches-feedstock#621 ). To fix this am redeploying the webservice action

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/7282581648.

@jakirkham
Copy link
Member

jakirkham commented Dec 21, 2023 •
edited
Loading

It's still pushing the image. Will try back in a bit

Edit: Nvm it just finished 😂

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham
Copy link
Member

Ok it's all cleared up. Latest re-rendering bot log

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libxgboost' output doesn't have any tests.
  • It looks like the '_py-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'py-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'py-xgboost-gpu' output doesn't have any tests.
  • It looks like the 'xgboost' output doesn't have any tests.
  • It looks like the '_r-xgboost-mutex' output doesn't have any tests.
  • It looks like the 'r-xgboost-cpu' output doesn't have any tests.
  • It looks like the 'r-xgboost-gpu' output doesn't have any tests.

@jakirkham
Copy link
Member

There are a bunch of CUDA bits in the noarch packages. Wondering if maybe we can push these back into libxgboost to simplify this a bit

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/xgboost-feedstock/actions/runs/7284946602.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge-webservices[bot] and others added 2 commits January 19, 2024 05:41
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jan 19, 2024
@github-actions github-actions bot merged commit 1f768db into conda-forge:main Jan 19, 2024
16 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham mentioned this pull request Jan 19, 2024
Merged
@hcho3 hcho3 deleted the use_noarch branch January 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp left review comments

@jakirkham jakirkham jakirkham left review comments

@aldanor aldanor Awaiting requested review from aldanor aldanor is a code owner

@fhoehle fhoehle Awaiting requested review from fhoehle fhoehle is a code owner

@ksangeek ksangeek Awaiting requested review from ksangeek ksangeek is a code owner

@mfansler mfansler Awaiting requested review from mfansler mfansler is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hcho3 @jakirkham @xhochy @jaimergp