Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about microarchitectures and build numbers #2094

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jaimergp
Copy link
Member

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/, you have added it to the sidebar in docs/sidebar.json
  • put any other relevant information below

Follow up to #2091
cc @traversaro

@jaimergp jaimergp requested a review from a team as a code owner February 28, 2024 23:01
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 9f4f772
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/65e07e0a3fedf800084c60fb
😎 Deploy Preview https://deploy-preview-2094--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beckermr
Copy link
Member

Did we want to put an actual example in the recipe here?

@beckermr
Copy link
Member

See what you think with my commit here @jaimergp @traversaro.

@jaimergp
Copy link
Member Author

LGTM! Makes me think whether we can multiply things in Jinja (I guess we can), but I don't think that's a good idea hah. Imagine:

number: {{ build + 100 * microarch_level }}    # [unix and x86_64 and microarch_level]

@beckermr
Copy link
Member

Yikes yeah I think this is better.

@beckermr beckermr merged commit ac4b5a4 into conda-forge:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants