-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Take 2 #10
Windows: Take 2 #10
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.04.20.18.36.07
So it seems like this builds fine. It is based on #7. It creates and installs a cunit.lib, but not a cunit.dll. I'm not a Windows person and have no idea whether there should be a dll, too. I commented out some stuff in the CMakeLists.txt as it was throwing an error. Could you have a look and let me know what you think @traversaro @wolfv? |
I think we just have to turn this option on |
project(CUnit LANGUAGES C) | ||
|
||
# Export all symbols when building a DLL on MSVC | ||
if(WIN32 AND MSVC AND BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tobias-Fischer here :)
thanks for picking this up, let's get it over the finish line this time :) |
dll is built, but installed into |
Do we have to comment the stuff in the CMakeLists back in? |
ah, no I think pdb files are for debugging. I just changed |
The last problem is that the check for existence checks for
|
FYI the |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)