Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagster v1.5.4 #296

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
dagster 1.5.4 Anaconda-Server Badge
grpcio-health-checking 1.59.0 Anaconda-Server Badge
mysql-connector-python 8.1.0 Anaconda-Server Badge
twilio 8.10.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6579492382, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl bollwyvl merged commit 99d984b into conda-forge:main Oct 20, 2023
3 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.5.4_haa8e7d branch October 20, 2023 14:14
@dhirschfeld
Copy link
Member

Hmm,
It looks like this failed on main:

import: 'dagstermill'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/test_tmp/run_test.py", line 2, in <module>
    import dagstermill
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/dagstermill/__init__.py", line 3, in <module>
    from .asset_factory import define_dagstermill_asset as define_dagstermill_asset
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/dagstermill/asset_factory.py", line 25, in <module>
    from dagstermill.factory import _clean_path_for_windows, execute_notebook
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/dagstermill/factory.py", line 10, in <module>
    import papermill
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/papermill/__init__.py", line 3, in <module>
    from .exceptions import PapermillException, PapermillExecutionError
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/papermill/exceptions.py", line 3, in <module>
    from ansiwrap import strip_color
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/ansiwrap/__init__.py", line 1, in <module>
    from .core import *
  File "/home/conda/feedstock_root/build_artifacts/dagster-meta_1697897168058/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.12/site-packages/ansiwrap/core.py", line 6, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'
Tests failed for dagstermill-1.5.4-pyhd8ed1ab_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for dagstermill-1.5.4-pyhd8ed1ab_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: dagstermill-1.5.4-pyhd8ed1ab_0.conda

I'm not too sure why this would pass here and only fail after merge?

ping @conda-forge/dagster

@dhirschfeld
Copy link
Member

imp has been removed in python=3.12:

https://docs.python.org/3/whatsnew/3.12.html#imp

...but that doesn't explain why it woudl work here 🤔

@dhirschfeld
Copy link
Member

ansiwrap is unmaintained, so whatever is depending on it probably shouldn't be:

image

jonathaneunice/ansiwrap#17

@dhirschfeld
Copy link
Member

It looks like papermill was patched in Oct-2022:

nteract/papermill#681

...but there has been no release incorporating it 😬

image

https://pypi.org/project/papermill/#history

@tom-pj
Copy link

tom-pj commented Dec 12, 2023

This can't be fixed on ansiwrap? @dhirschfeld @bollwyvl @jezdez @djsutherland

@dhirschfeld
Copy link
Member

This issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants