Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable windows build #7

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Enable windows build #7

merged 4 commits into from
Oct 9, 2018

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Oct 4, 2018

Based on PR #6.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pitrou
Copy link
Member Author

pitrou commented Oct 4, 2018

Note I'm not sure how to easily test this.

@wesm
Copy link
Member

wesm commented Oct 9, 2018

LGTM. I'm not a maintainer so cannot merge

@xmnlab xmnlab merged commit 7f3555b into conda-forge:master Oct 9, 2018
@xmnlab
Copy link
Member

xmnlab commented Oct 9, 2018

thanks @pitrou for working on that
and thanks @wesm for review that.

@pitrou pitrou deleted the enable-windows branch October 9, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pitrou @conda-forge-linter @wesm @xmnlab