Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant changes from upstream for LLVM 18 cycle #35

Closed
h-vetinari opened this issue Nov 10, 2023 · 4 comments
Closed

Relevant changes from upstream for LLVM 18 cycle #35

h-vetinari opened this issue Nov 10, 2023 · 4 comments

Comments

@h-vetinari
Copy link
Member

h-vetinari commented Nov 10, 2023

No claim of completeness.

Still waiting if the runtime lib refactor relands, as well as the switch to HLFIR as a default (looks close) [happened] or finally switching the name of the binary to flang.

@Krande
Copy link

Krande commented Apr 10, 2024

Hey @h-vetinari. By the looks of it, it seems most (if not all) of the referred issued are closed and merged into 18.1?

Over at the code-aster-feedstock we're looking into adding support for windows. Windows support would require us to enable Fortran support on multiple of our dependencies. I'd be happy to spend some time debugging flang-new issues on our dependencies. For references, here are the dependencies I am looking into

In my initial attempts on the hdf5 and mfront packages it seems I am running into some immediate failures (which I'd wager is mostly due to me not using the appropriate flags for flang-new).

When investigating the state of flang on windows and some of the errors I was seeing, I came across this error reported for the flang=18.1.2 conda-forge package (which I was able to reproduce with flang v18.1.3 on conda-forge and the same error is an issue when compiling mfront). I haven't tested compiling flang from source yet though, but I thought that would be the next logical step.

Any thoughts on the reported "fails to lower FIR" error for flang specifically on conda-forge?

For reference, the hdf5 compilation attempt failed with Fortran compiler requires either intrinsic functions SIZEOF or STORAGE_SIZE

@h-vetinari
Copy link
Member Author

Hey @Krande, thanks for the comment!

I already commented on the issue you're referencing (which I wasn't aware of - thanks!). Unless we uncover some failure in the packaging (certainly possible, but I'm not aware of anything at the moment), then anything with "lowering to FIR failed" is pretty obviously related to upstream flang to me. For context, FIR is the "Fortran Intermediate Representation" that the compiler uses to go from source code to machine code, and way more low-level than anything we're touching in the packaging.

@h-vetinari
Copy link
Member Author

By the looks of it, it seems most (if not all) of the referred issued are closed and merged into 18.1?

PS. Yes, all those commits were merged before 18.x even branched from main, so they're definitely part of the release. I mainly kept a list of relevant changes for myself from occasionally checking out what's happening upstream.

@h-vetinari
Copy link
Member Author

Closing this as we've published flang 18 a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants