Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of Gazebo plugins as linked libraries on macOS #218

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jun 2, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits June 2, 2024 12:48
@Tobias-Fischer
Copy link
Contributor

Should we use a glob instead? Anything with plugin in the name?

@traversaro
Copy link
Contributor Author

Should we use a glob instead? Anything with plugin in the name?

I think more and less everything in the $PREFIX/lib/gazebo-11/plugins folder has plugin in its name, so we could just iterate on the directory content. However, to reduce the chance of clobbering I would just keep that list, that is the one we actually need for gazebo-ros-plugins.

@Tobias-Fischer
Copy link
Contributor

Great, thanks for the explanation!

@traversaro traversaro merged commit f230fc7 into conda-forge:main Jun 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants