Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for pypy #55

Merged
merged 15 commits into from
Mar 27, 2020
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/15006, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor

blocked by conda-forge/ipython-feedstock#100

@bollwyvl
Copy link
Contributor

Should rekick this once CDN updates...

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 21, 2020 via email

@bollwyvl
Copy link
Contributor

Gah, the numpy stuff will complicate this.

More concerning is the kernelspec not getting rewritten on windows, the whole reason this thing is not noarch:

INFO :: Time taken to mark (prefix)
        0 replacements in 0 files was 0.03 seconds
...

then...

===== testing package: ipykernel-5.1.4-py36h95af2a2_1 =====
running run_test.py
Checking Kernelspec at:      %PREFIX%\share\jupyter\kernels\python3\kernel.json ...

{
 "argv": [
  "D:\\bld\\ipykernel_1584830829341\\_h_env\\python.exe",
  "-m",
  "ipykernel_launcher",
  "-f",
  "{connection_file}"
 ],
 "display_name": "Python 3",
 "language": "python"
}

Checking python executable D:\bld\ipykernel_1584830829341\_h_env\python.exe ...
The kernelspec seems to have the wrong prefix. 
Specfile: D:\bld\ipykernel_1584830829341\_h_env\python.exe
Expected: %PREFIX%\python.exe

@blink1073
Copy link
Member

Seeing the the same in #56.

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 22, 2020 via email

@bollwyvl
Copy link
Contributor

The build vars didn't work, alas.

The hack I've put up, which uses Path.as_posix() appears to work locally in a test VM.

It may be worth considering adopting such a convention for paths-in-JSON upstream.

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 22, 2020

@bollwyvl
Copy link
Contributor

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@bollwyvl
Copy link
Contributor

I guess we could pin conda-build for now? Oddly, though, it's working locally in a vm with:

(base) C:\git\ipykernel-feedstock>conda info

     active environment : base
    active env location : c:\mc3
            shell level : 1
       user config file : C:\Users\IEUser\.condarc
 populated config files :
          conda version : 4.8.3
    conda-build version : 3.19.1
         python version : 3.7.4.final.0
       virtual packages :
       base environment : c:\mc3  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : c:\mc3\pkgs
                          C:\Users\IEUser\.conda\pkgs
                          C:\Users\IEUser\AppData\Local\conda\conda\pkgs
       envs directories : c:\mc3\envs
                          C:\Users\IEUser\.conda\envs
                          C:\Users\IEUser\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/4.8.3 requests/2.22.0 CPython/3.7.4 Windows/10 Windows/10.0.17763
          administrator : False
             netrc file : None
           offline mode : False

which seems comparable to what's on win ci:

     active environment : None
       user config file : C:\Users\VssAdministrator\.condarc
 populated config files : C:\Users\VssAdministrator\.condarc
          conda version : 4.8.3
    conda-build version : 3.19.1
         python version : 3.6.10.final.0
       virtual packages : 
       base environment : C:\Miniconda  (writable)
           channel URLs : https://conda.anaconda.org/conda-forge/win-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : C:\Miniconda\pkgs
                          C:\Users\VssAdministrator\.conda\pkgs
                          C:\Users\VssAdministrator\AppData\Local\conda\conda\pkgs
       envs directories : C:\Miniconda\envs
                          C:\Users\VssAdministrator\.conda\envs
                          C:\Users\VssAdministrator\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/4.8.3 requests/2.23.0 CPython/3.6.10 Windows/10 Windows/10.0.14393
          administrator : True
             netrc file : None
           offline mode : False

@blink1073
Copy link
Member

Yeah, I'd say pin for now

@@ -64,22 +64,22 @@ jobs:

- task: CondaEnvironment@1
inputs:
packageSpecs: 'python=3.6 conda-build conda conda-forge::conda-forge-ci-setup=2' # Optional
packageSpecs: 'python=3.6 conda-build=3.18.11 conda conda-forge::conda-forge-ci-setup=2' # Optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll see if this works...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good sign:

Detected hard-coded path in text file share/jupyter/kernels/python3/kernel.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind applying this to #56 so we can get the release out?

@bollwyvl
Copy link
Contributor

course, it isn't going to fix our numpy issue, which i haven't even looked into...

@bollwyvl
Copy link
Contributor

Ok, pinning worked... now what to do with numpy... i guess we can do some jinja stuff? i'll have to look into what's available, unless somebody has ideas. will also ping gitter.

@bollwyvl
Copy link
Contributor

Merged #56, so once again will have to do a bunch of work to clean this up... sigh.

@bollwyvl
Copy link
Contributor

having a look...

@@ -49,5 +52,10 @@
if sys.platform == "darwin":
pytest_args += ["-k", "not (test_subprocess_error or test_subprocess_print)"]

# https://github.com/ipython/ipykernel/pull/496
if py_impl == "PyPy":
pytest_args += ["-k", "not (test_io_api)"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bollwyvl
Copy link
Contributor

I've verified that the test skip for test_io_api is firing locally, but still seeing some issues...

@bollwyvl
Copy link
Contributor

🎉

@bollwyvl
Copy link
Contributor

CI is looking good, will leave this open for a day-ish for anybody to comment. Thanks @isuruf for keeping the ball rolling in the meantime...

@bollwyvl
Copy link
Contributor

Let's go with it!

@bollwyvl bollwyvl merged commit 25704c1 into conda-forge:master Mar 27, 2020
@bollwyvl
Copy link
Contributor

Gah, one windows test flake...

@jakirkham
Copy link
Member

Should be possible to retrigger from the GitHub UI.

@bollwyvl
Copy link
Contributor

Should be possible to retrigger from the GitHub UI.

for future reference: where? whitespace commit sorted it in the meantime:

| linux-64/ipykernel-5.2.0-py36h0b673f9_1.tar.bz2
| linux-64/ipykernel-5.2.0-py36h95af2a2_1.tar.bz2
| linux-64/ipykernel-5.2.0-py37h43977f1_1.tar.bz2
| linux-64/ipykernel-5.2.0-py38h23f93f0_1.tar.bz2
| linux-aarch64/ipykernel-5.2.0-py36h0b673f9_1.tar.bz2
| linux-aarch64/ipykernel-5.2.0-py36hac0dd68_1.tar.bz2
| linux-aarch64/ipykernel-5.2.0-py37hc6149b9_1.tar.bz2 
| linux-aarch64/ipykernel-5.2.0-py38h1cdfbd6_1.tar.bz2
| linux-ppc64le/ipykernel-5.2.0-py36h0b673f9_1.tar.bz2
| linux-ppc64le/ipykernel-5.2.0-py36hac0dd68_1.tar.bz2
| linux-ppc64le/ipykernel-5.2.0-py37hc6149b9_1.tar.bz2
| linux-ppc64le/ipykernel-5.2.0-py38h1cdfbd6_1.tar.bz2
| osx-64/ipykernel-5.2.0-py36h0b673f9_1.tar.bz2
| osx-64/ipykernel-5.2.0-py36h95af2a2_1.tar.bz2
| osx-64/ipykernel-5.2.0-py37h43977f1_1.tar.bz2
| osx-64/ipykernel-5.2.0-py38h23f93f0_1.tar.bz2
| win-64/ipykernel-5.2.0-py36h5ca1d4c_1.tar.bz2
| win-64/ipykernel-5.2.0-py37h5ca1d4c_1.tar.bz2
| win-64/ipykernel-5.2.0-py38h5ca1d4c_1.tar.bz2

@jakirkham
Copy link
Member

  1. Navigate to the commit.
  2. Click the status next to it.
  3. Select "Details" next to an Azure build
  4. Click "Re-run checks" dropdown in upper right
  5. Select "Re-run failed checks"

If I do that with the merge commit of this PR, here's the page I get to.

@isuruf
Copy link
Member

isuruf commented Mar 27, 2020

@jakirkham, can you send a PR to docs about this?

@jakirkham
Copy link
Member

Not atm, but please feel free to grab it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants