Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for missing install name for mumps libraries on osx #105

Closed
wants to merge 8 commits into from

Conversation

jcapriot
Copy link
Contributor

@jcapriot jcapriot commented Dec 22, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

closes #103

I don't have a lot of experience building mumps, but looking through the downloaded files, this is where I would expect the issue is coming from.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jcapriot
Copy link
Contributor Author

Looks like #102 makes this same fix (in addition to the int-header issue)

@minrk
Copy link
Member

minrk commented Dec 22, 2023

Thanks! Yeah, I found this in #102 because it also re-enables the tests that hadn't been there. Other than weird openmpi cuda things, #102 should get things ready for 5.6, as far as I can tell.

@jcapriot
Copy link
Contributor Author

close in favor of #102

@jcapriot jcapriot closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect install name in osx mumps libraries
2 participants