Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkg-config files for mumps libs #109

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 20, 2024

closes #104

This is only for the public libs. Is it needed for mumps_common and/or pord?

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk changed the title add package-config files for mumps libs add pkg-config files for mumps libs Jan 20, 2024
@minrk minrk mentioned this pull request Jan 20, 2024
@akhmerov
Copy link
Contributor

I can't seem to find the job artifacts, where should I look?

@minrk
Copy link
Member Author

minrk commented Jan 20, 2024

Not at all obvious, but here:

link on job page:

Screenshot 2024-01-20 at 22 07 51

@akhmerov
Copy link
Contributor

This works!

Run-time dependency dmumps_seq found: YES 5.6.2
Run-time dependency zmumps_seq found: YES 5.6.2
Run-time dependency cmumps_seq found: YES 5.6.2
Run-time dependency smumps_seq found: YES 5.6.2

and the tests pass.

I also confirm that linking against mumps-common seems unnecessary (TIL).

I wonder whether the suffix -seq is the right way to go, but this is consistent with how the library itself is packaged.

@minrk
Copy link
Member Author

minrk commented Jan 21, 2024

I was thinking matching the library name (_seq) rather than the package name (-seq) would be the least surprising, but I don't have strong feeling. What do you think?

@akhmerov
Copy link
Contributor

Makes sense. I think this is good to go.

@minrk minrk merged commit 8206f7d into conda-forge:main Jan 21, 2024
18 checks passed
@minrk minrk deleted the pkg-config branch January 21, 2024 20:15
@minrk
Copy link
Member Author

minrk commented Jan 21, 2024

Thanks!

@jcapriot
Copy link
Contributor

Btw, I don’t think this will generate correct confit files for windows.

Libs: -L${{libdir}} -l{NAME}
"""

prefix = Path(os.environ["PREFIX"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when on windows, "/Library" needs to be append to prefix: There should also be a LIBRARY_PREFIX environment variable in conda-build recipes on windows that would point to this correct path

prefix = Path(os.environ.get("LIBRARY_PATH", os.environ["PREFIX"]))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize pkg-config was a thing on Windows! This doesn't generate files for Windows at all.

If you know what they should be, a PR updating the script and adding it to bld.bat would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgconfig
3 participants