-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pkg-config files for mumps libs #109
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I can't seem to find the job artifacts, where should I look? |
Not at all obvious, but here: link on job page: ![]() |
This works! Run-time dependency dmumps_seq found: YES 5.6.2
Run-time dependency zmumps_seq found: YES 5.6.2
Run-time dependency cmumps_seq found: YES 5.6.2
Run-time dependency smumps_seq found: YES 5.6.2 and the tests pass. I also confirm that linking against mumps-common seems unnecessary (TIL). I wonder whether the suffix |
I was thinking matching the library name ( |
Makes sense. I think this is good to go. |
Thanks! |
Btw, I don’t think this will generate correct confit files for windows. |
Libs: -L${{libdir}} -l{NAME} | ||
""" | ||
|
||
prefix = Path(os.environ["PREFIX"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when on windows, "/Library" needs to be append to prefix: There should also be a LIBRARY_PREFIX
environment variable in conda-build recipes on windows that would point to this correct path
prefix = Path(os.environ.get("LIBRARY_PATH", os.environ["PREFIX"]))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize pkg-config was a thing on Windows! This doesn't generate files for Windows at all.
If you know what they should be, a PR updating the script and adding it to bld.bat would be much appreciated.
closes #104
This is only for the public libs. Is it needed for mumps_common and/or pord?