-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for python39 #205
Rebuild for python39 #205
Conversation
…da-forge-pinning 2020.10.09.16.47.17
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like we need to adapt something in the tests:
That does not sound like a problematic failure. |
We got a patch release merged here recently. Maybe we can just retry CI? @conda-forge-admin, please restart CI |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
The log is too long on mobile but I would guess from the error that the |
@conda-forge-admin, please restart ci (conda-forge/pytest-feedstock#126 just finished) |
It may take a while for the package to be available. We may need to restart it again. |
Though on second thought, this will almost certainly run into the same problem with |
Seems we can get away without hypothesis (should be disabled if not present), but it (still?) picks up a very old pytest version:
I just installed a local 3.9 env, and pytest worked without issue. Seems the cache was updated in the meantime. Let's try again: |
3.9. builds now passed for linux/osx. But I'm thinking the migrator might have wrong meta-data regarding the numpy version? Or should we build 1.18 for python 3.9 as well? |
All the 3.9 builds are green (the pypy aarch build timed out due to drone being confused with the restarts, I believe), but I think (most) dependent packages will still fail without the availability of 1.18 for 3.9, due to the config of the migrator. |
We should fix the migrator before merging. Then we don't need to fix any generated PRs. As we don't do rebuilds on new targets with old versions, we should set the numpy version to 1.19 for Python 3.9. |
I'm working on a PR for 1.16 which is the version we are pinning. |
We bumped to 1.19 for python3.9 in conda-forge/conda-forge-pinning-feedstock#851 |
Awesome! I guess that some rebuilds of older version don't hurt but I'm 👍 on bumping the pin. |
There's a bunch of numpy-related solver errors in the 3.9 migration, including several high-impact packages like Also, while not critical for the migration, the aarch+pypy build (after merging this PR) timed out on master as well. |
Some builds on master timed out, we need to wait for at least 1-2h until they are up on the CDN and the bot has been rerun. Seems like the performance on Drone has a very high variance in the last days and some machines are up 4x slower than the rest (seeing this also on the arrow-cpp-feedstock). |
I expect those were caused by the Windows build failure which has now been retried. I suspect the bot will soon figure out that the problem has been resolved. |
This PR has been triggered in an effort to update python39.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
imagecodecs
ipykernel
opencv
pandas
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by , please use this URL for debugging