Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Update to omniscidb 5.5.0 #26

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Jan 12, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pearu pearu self-assigned this Jan 12, 2021
@pearu
Copy link
Contributor Author

pearu commented Jan 12, 2021

@jclay @andrewseidl @xmnlab please review.

Once this PR is merged, the plan is to update #22 to enable pyomniscidb as well.

@@ -34,26 +32,27 @@ requirements:
- {{ compiler('cgo') }}
- {{ compiler('cxx') }}
- {{ compiler("cuda") }} # [cuda_compiler_version not in (undefined, "None")]
# omniscidb 5.4 is not LLVM 11 ready
- clangdev <11
# omniscidb 5.5 is not LLVM 12 ready
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: maybe if we have this constraint < 12 constantly, we could change it (in the future) to a variable (maybe LLVM_UNSUPPORTED_VERSION or something similar) and we could just change the variable value when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hope that at some point we could remove the constraint on the LLVM version altogether. Meanwhile, maintaining it within the meta.yaml is straightforward, and adding the extra boilerplate is not worth it, IMHO.

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @pearu

@pearu pearu merged commit 64963d0 into conda-forge:master Jan 12, 2021
@pearu pearu deleted the pearu/5.5.0 branch January 12, 2021 20:41
@pearu pearu mentioned this pull request Feb 2, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants