-
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
…da-forge-pinning 2021.01.12.15.04.08
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jclay @andrewseidl @xmnlab please review. Once this PR is merged, the plan is to update #22 to enable pyomniscidb as well. |
@@ -34,26 +32,27 @@ requirements: | |||
- {{ compiler('cgo') }} | |||
- {{ compiler('cxx') }} | |||
- {{ compiler("cuda") }} # [cuda_compiler_version not in (undefined, "None")] | |||
# omniscidb 5.4 is not LLVM 11 ready | |||
- clangdev <11 | |||
# omniscidb 5.5 is not LLVM 12 ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: maybe if we have this constraint < 12
constantly, we could change it (in the future) to a variable (maybe LLVM_UNSUPPORTED_VERSION or something similar) and we could just change the variable value when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would hope that at some point we could remove the constraint on the LLVM version altogether. Meanwhile, maintaining it within the meta.yaml is straightforward, and adding the extra boilerplate is not worth it, IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you @pearu
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)