-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add openmp on windows #115
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin rerender |
…da-forge-pinning 2021.01.31.00.18.44
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@h-vetinari Do you know why flang 5 was installed? It should have been flang 11. |
I guess there's cache in conda-forge-admin that's waiting to catch up. |
It can take up to 90min until the finished package has made it through to the content delivery network (CDN), from which it is downloaded. As soon as you see download numbers >1 for the newest build here, that should be the case. |
We pin to flang 5 at the moment. We'll need to rebuild all the packages with flang 11. We have a bot that can do that. Just needs to find time to do that. |
@isuruf where is that flang-5 defined? In some repository? |
Here: https://github.com/conda-forge/conda-forge-pinning-feedstock/ Wasn't aware that flang was pinned as well - but didn't @xoviat say that the ABI is compatible? Would it make sense to just relax the pin, instead of having a migrator? Or would that be too risky? @isuruf |
@h-vetinari flang ABI is NOT compatible! see conda-forge/flang-feedstock#9 |
Ah, sorry, my bad - brainfart. |
come to think of it, when f18 eventually comes out in a year or two, we'll have the same situation where another patch to the packages will be required. Oh well. |
Not seen on Linux (though I had to remove all gcc-style instruction set options like |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
6eb1e49
to
89f1ffa
Compare
…nda-forge-pinning 2024.07.08.07.05.49
Good news @conda-forge/openblas: with the in-progress flang 19, we can build OpenBLAS and pass the test suite, both with/without OpenMP. 🥳 For more background: llvm/llvm-project#86463 & OpenMathLib/OpenBLAS#4768 There's a positively shocking performance difference in the test suite with/without OpenMP pthreads build (i.e. without OpenMP)
and the OpenMP-enabled one:
By way of comparison, the current pthread build on
I honestly don't know why this difference is so large, but I'm assuming the pthreads variant has some issues (c.f. #160). Furthermore, there are some issues with AVX512 instructions (see OpenMathLib/OpenBLAS#4789) which will have to be fixed in LLVM, but for now the workaround that OpenBLAS is using itself ( All in all, it looks like with flang 19 in ~September, we should finally be able to switch our Fortran compilers on windows over to llvm-flang. CC @martin-frbg @conda-forge/core |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.08.17.00.11.41
@conda-forge/openblas, this is ready for review (aside from reverting 153ce91 and waiting for the release of LLVM 19, but that's just a question of ~2 weeks), PTAL! :) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)