-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set -DLIBOMP_FORTRAN_MODULES=ON
on windows
#134
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is quite curious. We cannot build the fortran bits of OpenMP 18 with flang 18, but it works if either of the versions is bumped to 19. In this PR we bump the flang version, on the In any case, even if we don't merge this for OpenMP 18, I want to enable this for OpenMP 19, so I'd appreciate feedback @conda-forge/openmp |
Gentle ping on this @conda-forge/openmp |
Can we move the |
- _openmp_mutex | ||
ignore_run_exports_from: | ||
- {{ compiler("cxx") }} | ||
- {{ compiler("fortran") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .mod
files are specific to the gfortran version (maybe not the major version, but the soversion. not sure), so it's not possible to remove these.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@isuruf, I've rebased this PR on #144 and added the output you wanted - I think I've incorporated all the feedback so far on this here. I still want to clean up the commit history better, but the content of the changes should be OK now. As such, I'd ask you to please review this at your earliest convenience. |
Gentle ping @isuruf |
Thanks for the review; should be fixed now. |
Co-Authored-By: Isuru Fernando <isuruf@gmail.com>
-DLIBOMP_FORTRAN_MODULES=ON
-DLIBOMP_FORTRAN_MODULES=ON
on windows
Good now? |
I think we're close here @isuruf, can you please help me wrap this up? |
If we want to build OpenBLAS with OpenMP support with flang (c.f. conda-forge/openblas-feedstock#115), we'll need to package the Fortran bits of OpenMP, otherwise we run into:
Flang 18 is going to be unusable to build OpenBLAS, but I'd like to open this for discussion/review already, so we can figure this out before LLVM 19 releases.
PS. This is rebased from the
dev
branch, with which I was able to get CI green in conda-forge/openblas-feedstock#115.