-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin-compatible, use boost-cpp instead of boost #1
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@dougalsutherland The |
Yeah, this naming scheme always gets me. Thanks for the reminder @dougalsutherland! |
We can avoid Travis timeouts by using Circle for OSX, which has a longer timeout. :) Also skipped VC9 since that seems to not work. I guess the AppVeyor build for VC14 also timed out, though; not sure if there's anything we can do about that.... |
Could use |
FYI - CircleCI macOS builds are slowed. |
I must be missing something. Looks like Appveyor is still trying to build |
Huh, I thought that worked but obviously didn't check properly. This will. Also switching to |
vc9 doesn't work because that's a variable that isn't defined. vc is defined, because it is part of conda_build_config.yaml. py35 and such were hard-coded. https://github.com/conda/conda-build/blob/master/conda_build/metadata.py#L99 I probably won't maintain the hardcoded crap going forward. |
That or we could do this...
xref: conda/conda-build#1202 |
About
boost
:The naming is confusing, but the
boost
package includesboost::python
; you should only needboost-cpp
here.The
boost-cpp
(andboost
) recipes don't have apin_run_as_build
entry (yet – pin_run_as_build for boost, boost-cpp conda-forge-pinning-feedstock#58), and so you need to explicitlypin_compatible
to ensure that a compatible version of the library is used at runtime as at build time.I removed the
skip
forpy!=36
; as-is, I think it would have been impossible to install on python2.7 on Linux, for example. I'm allowing avc9
build here, but if that fails we can skip it withskip: true # [vc9]
.cc @scopatz, FYI.