Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler v21.12.0 #121

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1527406442, please use this URL for debugging

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
nss 3.73 Anaconda-Server Badge
poppler 21.12.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows no discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pkgw
Copy link
Contributor

pkgw commented Dec 2, 2021

Windows compile failure in poppler/ImageEmbeddingUtils.cc:

C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared\basetsd.h(77): error C2371: 'INT32': redefinition; different basic types
d:\bld\poppler-split_1638388910887\_h_env\library\include\jmorecfg.h(216): note: see declaration of 'INT32'

@pkgw
Copy link
Contributor

pkgw commented Dec 2, 2021

Another Windows compile failure:

D:\bld\poppler-split_1638406403698\work\glib\poppler-document.cc(34): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory

Other files use a guard:

#ifdef HAVE_UNISTD_H
#    include <unistd.h>
#endif

update: Then:

glib\poppler-document.cc(3480): error C3861: 'close': identifier not found

update 2: OK, there are enough issues in the new glib FD APIs that we're not going to be able to get them to build on Windows in any reasonable way. Filed upstream: https://gitlab.freedesktop.org/poppler/poppler/-/issues/1180

@Fdawgs
Copy link
Contributor

Fdawgs commented Dec 20, 2021

Thanks for chasing this @pkgw!

@oschwartz10612
Copy link
Contributor

@conda-forge-admin, please rerender

@Fdawgs
Copy link
Contributor

Fdawgs commented Jan 12, 2022

Is it worth leapfrogging this version? v22.01.0 seems to have included all the fixes requested in https://gitlab.freedesktop.org/poppler/poppler/-/issues/1180

@pkgw
Copy link
Contributor

pkgw commented Jan 12, 2022

@Fdawgs Yes, we should just skip this one. Hopefully the bot will file a PR for 22.01 soon, but someone can always do that manually too. I'll close this PR since there's a new version to work on now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants