Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11.0a3 #535

Closed
wants to merge 3 commits into from
Closed

Python 3.11.0a3 #535

wants to merge 3 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Dec 22, 2021

I would like to build the alpha releases from time to time as I hope this will make the work for us easier once the release (candidates) come out.

Also, I did comment out the downstream tests, is there a better solution?

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member

isuruf commented Dec 23, 2021

2>dynload_win.obj : error LNK2001: unresolved external symbol _CondaEcosystemModifyDllSearchPath [D:\bld\python-split_1640193704982\work\PCbuild\_freeze_module.vcxproj]
     2>pylifecycle.obj : error LNK2001: unresolved external symbol _CondaEcosystemModifyDllSearchPath_Init [D:\bld\python-split_1640193704982\work\PCbuild\_freeze_module.vcxproj]
     2>D:\bld\python-split_1640193704982\work\PCbuild\win32\_freeze_module.exe : fatal error LNK1120: 2 unresolved externals [D:\bld\python-split_1640193704982\work\PCbuild\_freeze_module.vcxproj]

@h-vetinari
Copy link
Member

3.11.0beta1 has now been released - is it perhaps time to respin this PR?

@xhochy
Copy link
Member Author

xhochy commented May 12, 2022

Happy to continue to work on this, my main issue is to fix the line endings in recipe/patches/0014-Add-CondaEcosystemModifyDllSearchPath.patch. Otherwise, this should be building. The line endings freaked me out though.

@isuruf
Copy link
Member

isuruf commented May 12, 2022

We should get rid of CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1 mode entirely anyways. I'll have a look at refreshing that patch.

@isuruf
Copy link
Member

isuruf commented Oct 25, 2022

Closing in favour of #577

@isuruf isuruf closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants