Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcelemental v0.6.0 #19

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Aug 14, 2019

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed
  • Tests have passed
  • Updated license if changed and license_file is packaged

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@Lnaden Lnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pins updated. Once passed I'll merge in.

@loriab
Copy link
Contributor

loriab commented Aug 14, 2019

@Lnaden worth adding python-msgpack?

@Lnaden
Copy link
Contributor

Lnaden commented Aug 14, 2019

Good question, its not strictly required, so I don't know if we should. @dgasmith thoughts?

@dgasmith
Copy link
Contributor

I say yes since we include py3dmoljs here as well.

@Lnaden
Copy link
Contributor

Lnaden commented Aug 14, 2019

We only require it for the tests, the recipe does not require it

@dgasmith
Copy link
Contributor

Ah, then lets skip.

@dgasmith dgasmith merged commit 9fe4594 into conda-forge:master Aug 14, 2019
@Lnaden
Copy link
Contributor

Lnaden commented Aug 14, 2019

We can change our mind later if we want

@loriab
Copy link
Contributor

loriab commented Aug 14, 2019

I vote yes, include it, because its deps (libgcc-ng, libstdcxx-ng, python) are dependencies already.

@dgasmith
Copy link
Contributor

Turn this into an issue and we can dig into it on next bump?

@Lnaden
Copy link
Contributor

Lnaden commented Aug 14, 2019

Can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants