-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore deactivate-r-base.sh #69
Conversation
Restores deactivation script which was lost since commit 6b81c0f
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
@conda-forge/help-r Anyone to help with this please? |
@conda-forge/r-base |
@PertuyF Thanks for catching this regression and submitting a fix!
The builds are failing to download the file @conda-forge-admin, please rerender |
…nda-forge-pinning 2019.02.15
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like the Windows build is failing during the MiKTeX installation. I suspect that the download URL might need to be updated, since we've had to do this before in the past. |
Updating MiKTeX url worked, but now Azure pipeline for win vs2008 failed on: |
Just to mention, the mirror used for MiKTeX has an url of the form But also Do you think we should use this one? or keep the current url? |
@isuruf Could you please provide your thoughts on 1) the failed vs2008 Azure build, and 2) the MiKTeK download URL? From @PertuyF:
|
The Azure pipeline failure can probably be ignored. See conda-forge/staged-recipes#7822 (comment) |
@jdblischak, @isuruf what should we do with this PR? merge as-is? rerender? Should we finally change miktex url to the portable version? |
@PertuyF I think it is more important to know which version was used with each build.
@bgruening @croth1 How do we want to coordinate this PR with #78? |
@jdblischak I just wanted to encourage a rerender due to very old pins. If this one is ok, please go ahead, merge it and close mine. |
@conda-forge-admin, please re-render @croth1 sounds like a plan! |
…da-forge-pinning 2019.03.17
@bgruening Looks like we're good to go 😄 |
Ok, let go for it and reserve some time for potential fallouts :) |
Restores
$CONDA_PREFIX/etc/conda/deactivate.d/deactivate-r-base.sh
script which was lost since commit6b81c0f
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)