Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deactivate-r-base.sh #69

Merged
merged 5 commits into from
Mar 29, 2019
Merged

Conversation

PertuyF
Copy link
Contributor

@PertuyF PertuyF commented Feb 13, 2019

Restores $CONDA_PREFIX/etc/conda/deactivate.d/deactivate-r-base.sh script which was lost since commit 6b81c0f.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Restores deactivation script which was lost since commit 6b81c0f
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@PertuyF
Copy link
Contributor Author

PertuyF commented Feb 13, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@PertuyF
Copy link
Contributor Author

PertuyF commented Feb 13, 2019

@conda-forge/help-r Anyone to help with this please?

@PertuyF
Copy link
Contributor Author

PertuyF commented Feb 17, 2019

@conda-forge/r-base

@jdblischak
Copy link
Member

Restores $CONDA_PREFIX/etc/conda/deactivate.d/deactivate-r-base.sh script which was lost since commit 6b81c0f.

@PertuyF Thanks for catching this regression and submitting a fix!

Anyone to help with this please?

The builds are failing to download the file ff_ci_pr_build.py which no longer exists at https://raw.githubusercontent.com/conda-forge/conda-forge-ci-setup-feedstock/branch2.0/recipe/conda_forge_ci_setup/ff_ci_pr_build.py. You did the right thing by trying to rerender to update the CI scripts. Hopefully by now the updated scripts are available.

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jdblischak
Copy link
Member

Looks like the Windows build is failing during the MiKTeX installation. I suspect that the download URL might need to be updated, since we've had to do this before in the past.

@PertuyF
Copy link
Contributor Author

PertuyF commented Feb 18, 2019

Updating MiKTeX url worked, but now Azure pipeline for win vs2008 failed on: mv: cannot move 'D:/bld/r-base_1550523559484/work/lib/R/Tcl/Library/mingw-w64/lib' to 'D:/bld/r-base_1550523559484/work/lib/R/Tcl/lib': Permission denied.
It is strange as installation of m2w64 succeeded for win vs2015 build.

@PertuyF
Copy link
Contributor Author

PertuyF commented Feb 18, 2019

Just to mention, the mirror used for MiKTeX has an url of the form https://miktex.org/download/ctan/systems/win32/miktex/setup/windows-x86/miktex-portable-${MIKTEX_VER}.exe, currently used in the recipe, which requires to specify the version.

But also https://miktex.org/download/ctan/systems/win32/miktex/setup/windows-x86/miktex-portable.exe which looks more stable and could prevent future break. Although at the price of not knowing which version was used from the build.sh script...

Do you think we should use this one? or keep the current url?

@jdblischak
Copy link
Member

@isuruf Could you please provide your thoughts on 1) the failed vs2008 Azure build, and 2) the MiKTeK download URL?

From @PertuyF:

Azure pipeline for win vs2008 failed on: mv: cannot move 'D:/bld/r-base_1550523559484/work/lib/R/Tcl/Library/mingw-w64/lib' to 'D:/bld/r-base_1550523559484/work/lib/R/Tcl/lib': Permission denied.

But also https://miktex.org/download/ctan/systems/win32/miktex/setup/windows-x86/miktex-portable.exe which looks more stable and could prevent future break. Although at the price of not knowing which version was used from the build.sh script...

@jdblischak
Copy link
Member

The Azure pipeline failure can probably be ignored. See conda-forge/staged-recipes#7822 (comment)

@jdblischak jdblischak mentioned this pull request Mar 25, 2019
5 tasks
@PertuyF
Copy link
Contributor Author

PertuyF commented Mar 28, 2019

@jdblischak, @isuruf what should we do with this PR? merge as-is? rerender?

Should we finally change miktex url to the portable version?

@jdblischak
Copy link
Member

Should we finally change miktex url to the portable version?

@PertuyF I think it is more important to know which version was used with each build.

what should we do with this PR? merge as-is? rerender?

@bgruening @croth1 How do we want to coordinate this PR with #78?

@croth1
Copy link

croth1 commented Mar 28, 2019

@jdblischak I just wanted to encourage a rerender due to very old pins. If this one is ok, please go ahead, merge it and close mine.

@bgruening
Copy link
Contributor

@conda-forge-admin, please re-render

@croth1 sounds like a plan!

@PertuyF
Copy link
Contributor Author

PertuyF commented Mar 28, 2019

@bgruening Looks like we're good to go 😄
Thanks all!

@bgruening
Copy link
Contributor

Ok, let go for it and reserve some time for potential fallouts :)

@bgruening bgruening merged commit 9934a07 into conda-forge:master Mar 29, 2019
@PertuyF PertuyF deleted the patch-1 branch October 26, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants