Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build no to catch up to latest GDAL #173

Closed
wants to merge 2 commits into from

Conversation

hobu
Copy link

@hobu hobu commented Sep 10, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hobu
Copy link
Author

hobu commented Sep 10, 2020

@conda-forge-admin please rerender

@xylar
Copy link
Contributor

xylar commented Sep 10, 2020

@hobu, I'm hoping you have a secret touch that I was lacking in #171 and #172

@hobu
Copy link
Author

hobu commented Sep 10, 2020

@hobu, I'm hoping you have a secret touch that I was lacking in #171 and #172

Nope, I just neglected to search for any previous attempts 😄

@xylar
Copy link
Contributor

xylar commented Sep 10, 2020

Note, GDAL is being pegged via:
https://github.com/conda-forge/rasterio-feedstock/blob/master/recipe/conda_build_config.yaml#L1-L3
so unless you remove that, a rerender won't take care of this.

I found that tests failed with the latest GDAL and we're hoping (based on little evidence) that the latest proj (7.1.1) might work but that migration is currently stuck on GDAL's windows build: conda-forge/gdal-feedstock#411, as is an attempt to update to the latest GDAL version: conda-forge/gdal-feedstock#410

Long story sort, I think we're not yet at a point where rasterio is ready to be updated to the latest gdal/proj.

@hobu
Copy link
Author

hobu commented Sep 10, 2020

Thanks for the background. That GDAL error looks like something must have changed in the windows include path resolution or definition for the Python extensions.

It would be better for everyone if we just moved those bindings out of GDAL's tree entirely and managed them like normal Python extensions are managed nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants