-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Remove libgdal matrix, update to gdal 3.1 (take 2) #172
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2020.09.07.21.12.35
Based on this comment from the developer: https://rasterio.groups.io/g/main/message/600, it seems like rasterio 1.1.5 will work with libgdal 3.1 and proj 7.1.0 I wasn't able to re-open #171 because the branch had been deleted so I'm opening a new PR. |
@akrherz, many tests are failing with GDAL 3.1.2. If you want to dig into this and try to figure out why, that would be great. I don't really have time. |
Thank you @xylar ! I am reviewing this all now. |
It appears to me the test failures are just with |
We could test against proj |
Yeah, we can't even test with |
We would need to do a test build of all of the dependencies that need But I'll leave it open until I get your agreement, @akrherz |
That's reasonable, you have already gone way above and beyond here. Thanks again. |
So you would need to do local builds of those three and |
I started a migration to the new proj 7.1.1. I would love to move to a x.x or even x pinning in proj but their history of breaking things is in micro releases is not encouraging. |
Oh, that's great!
Yeah, there's a tricky balance to be had between making things easier for us and breaking things. In the end, it seems like stricter pins are often worth the pain. It's such a mess to clean things up if the pin is too loose. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)